falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 38151: FALCON-1250: Throw error when keys in startup.properties do not start with "*." or domain+"."
Date Tue, 08 Sep 2015 12:28:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38151/#review97992
-----------------------------------------------------------

Ship it!


Ship It!

- Ajay Yadava


On Sept. 7, 2015, 7:48 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38151/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 7:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> In org.apache.falcon.util.ApplicationProperties.java, method doLoadProperties only loads
the keys that start with domain + "."  or "*.".  All other keys are ignored.  
> 
> If the keys do not start with domain + "."  or "*.", it is probably because the user
made a typo or mistake in the startup.properties. Instead of ignoring these keys, I propose
that an error should be  thrown.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 1d8cf49 
>   common/src/main/resources/startup.properties c48188c 
> 
> Diff: https://reviews.apache.org/r/38151/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message