falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Narayan Periwal" <narayan.peri...@inmobi.com>
Subject Review Request 38151: FALCON-1250: Throw error when keys in startup.properties do not start with "*." or domain+"."
Date Mon, 07 Sep 2015 07:48:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38151/
-----------------------------------------------------------

Review request for Falcon.


Repository: falcon-git


Description
-------

In org.apache.falcon.util.ApplicationProperties.java, method doLoadProperties only loads the
keys that start with domain + "."  or "*.".  All other keys are ignored.  

If the keys do not start with domain + "."  or "*.", it is probably because the user made
a typo or mistake in the startup.properties. Instead of ignoring these keys, I propose that
an error should be  thrown.


Diffs
-----

  common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 1d8cf49 
  common/src/main/resources/startup.properties c48188c 

Diff: https://reviews.apache.org/r/38151/diff/


Testing
-------

Done.


Thanks,

Narayan Periwal


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message