falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Narayan Periwal" <narayan.peri...@inmobi.com>
Subject Re: Review Request 38005: FALCON-1381: The webservice response of Falcon includes a stack trace in case of errors
Date Wed, 02 Sep 2015 06:55:16 GMT


> On Sept. 2, 2015, 6:28 a.m., Pallavi Rao wrote:
> > prism/src/main/java/org/apache/falcon/FalconWebException.java, line 104
> > <https://reviews.apache.org/r/38005/diff/2/?file=1062090#file1062090line104>
> >
> >     Nit : Can we say "Caused By:" instead of just "\n"

"\n" was used to separate the error message and the message due to the cause. I will add "Caused
By" as well


- Narayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38005/#review97415
-----------------------------------------------------------


On Sept. 2, 2015, 6:24 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38005/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 6:24 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> IMO, we should just return a good error message. The stack trace shouldn't really be
the users concern.
> 
> 
> Diffs
> -----
> 
>   prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7 
> 
> Diff: https://reviews.apache.org/r/38005/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message