Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BFC22178D0 for ; Mon, 31 Aug 2015 19:54:23 +0000 (UTC) Received: (qmail 43109 invoked by uid 500); 31 Aug 2015 19:54:23 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 43067 invoked by uid 500); 31 Aug 2015 19:54:23 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 43055 invoked by uid 99); 31 Aug 2015 19:54:23 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Aug 2015 19:54:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id EA5011AB2EC for ; Mon, 31 Aug 2015 19:54:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.975 X-Spam-Level: *** X-Spam-Status: No, score=3.975 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.006] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5yjTSn2TyVnD for ; Mon, 31 Aug 2015 19:54:21 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 79A1D50725 for ; Mon, 31 Aug 2015 19:54:20 +0000 (UTC) Received: (qmail 43044 invoked by uid 99); 31 Aug 2015 19:54:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Aug 2015 19:54:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BD2D126D622; Mon, 31 Aug 2015 19:54:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0447107451546375300==" MIME-Version: 1.0 Subject: Re: Review Request 37771: Falcon Proxy user support From: "Balu Vellanki" To: "Balu Vellanki" , "Sowmya Ramesh" , "Falcon" Date: Mon, 31 Aug 2015 19:54:18 -0000 Message-ID: <20150831195418.16295.90009@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Balu Vellanki" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37771/ X-Sender: "Balu Vellanki" References: <20150827215016.13583.67148@reviews.apache.org> In-Reply-To: <20150827215016.13583.67148@reviews.apache.org> Reply-To: "Balu Vellanki" X-ReviewRequest-Repository: falcon-git --===============0447107451546375300== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37771/#review97130 ----------------------------------------------------------- Ship it! +1 Looks good to me. - Balu Vellanki On Aug. 27, 2015, 9:50 p.m., Sowmya Ramesh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37771/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 9:50 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1027 > https://issues.apache.org/jira/browse/FALCON-1027 > > > Repository: falcon-git > > > Description > ------- > > Today, Falcon doesn’t have doAs capability i.e. it doesn’t support impersonation. Support for impersonation or proxyuser functionality (identical to Hadoop proxyuser capabilities and conceptually similar to Unix 'sudo') needs to be added to REST API’s and CLI(Command > line). > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 11dfe72 > client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java 2f57c7d > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b > client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2 > common/src/main/java/org/apache/falcon/security/CurrentUser.java 4aed5d7 > common/src/main/java/org/apache/falcon/security/SecurityUtil.java 861f80f > common/src/main/java/org/apache/falcon/service/GroupsService.java PRE-CREATION > common/src/main/java/org/apache/falcon/service/ProxyUserService.java PRE-CREATION > common/src/main/resources/startup.properties c48188c > common/src/test/java/org/apache/falcon/security/CurrentUserTest.java 9a3f365 > common/src/test/java/org/apache/falcon/security/SecurityUtilTest.java 6e77462 > common/src/test/java/org/apache/falcon/service/GroupsServiceTest.java PRE-CREATION > common/src/test/java/org/apache/falcon/service/ProxyUserServiceTest.java PRE-CREATION > docs/src/site/twiki/FalconCLI.twiki 9203699 > docs/src/site/twiki/FalconDocumentation.twiki 29d93f7 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 5b415a2 > prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 78f68ba > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06 > prism/src/main/java/org/apache/falcon/security/FalconAuthenticationFilter.java df64b44 > prism/src/main/java/org/apache/falcon/security/FalconAuthorizationFilter.java 15e94cd > prism/src/main/java/org/apache/falcon/security/HostnameFilter.java PRE-CREATION > prism/src/main/webapp/WEB-INF/web.xml 551bf56 > prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java cce8737 > prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 9e8c76a > prism/src/test/java/org/apache/falcon/security/HostnameFilterTest.java PRE-CREATION > src/conf/startup.properties 9925373 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301 > webapp/pom.xml 5a9e1da > webapp/src/conf/oozie/conf/oozie-site.xml ded4873 > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b > webapp/src/main/webapp/WEB-INF/distributed/web.xml 31d78a2 > webapp/src/main/webapp/WEB-INF/embedded/web.xml fa2db39 > webapp/src/main/webapp/WEB-INF/web.xml 2cfd7de > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0062070 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f0cee61 > webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java eb1dda8 > webapp/src/test/java/org/apache/falcon/resource/TestContext.java 4a25b88 > webapp/src/test/resources/startup.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/37771/diff/ > > > Testing > ------- > > Unit tests and IT tests. > > > Thanks, > > Sowmya Ramesh > > --===============0447107451546375300==--