Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3383518998 for ; Thu, 27 Aug 2015 18:25:53 +0000 (UTC) Received: (qmail 47361 invoked by uid 500); 27 Aug 2015 18:25:53 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 47313 invoked by uid 500); 27 Aug 2015 18:25:53 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 47302 invoked by uid 99); 27 Aug 2015 18:25:52 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Aug 2015 18:25:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5BDB0EEC97 for ; Thu, 27 Aug 2015 18:25:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.563 X-Spam-Level: ** X-Spam-Status: No, score=2.563 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.007, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.424] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XdcGMFtcHfSc for ; Thu, 27 Aug 2015 18:25:51 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 2EA1025768 for ; Thu, 27 Aug 2015 18:25:49 +0000 (UTC) Received: (qmail 47199 invoked by uid 99); 27 Aug 2015 18:25:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Aug 2015 18:25:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 83B5126C3DC; Thu, 27 Aug 2015 18:25:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1026951717416905180==" MIME-Version: 1.0 Subject: Re: Review Request 37837: FALCON-1416: Add ACL (if missing) during touch From: "Balu Vellanki" To: "Balu Vellanki" , "sandeep samudrala" , "Falcon" , "Narayan Periwal" Date: Thu, 27 Aug 2015 18:25:48 -0000 Message-ID: <20150827182548.13584.11490@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Balu Vellanki" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37837/ X-Sender: "Balu Vellanki" References: <20150827180543.13584.23556@reviews.apache.org> In-Reply-To: <20150827180543.13584.23556@reviews.apache.org> Reply-To: "Balu Vellanki" X-ReviewRequest-Repository: falcon-git --===============1026951717416905180== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 27, 2015, 6:05 p.m., Balu Vellanki wrote: > > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java, line 425 > > > > > > Shouldn't the entity be decorated with ACL if authorization is enabled, and skip decoration if authorization is disabled? > > > > This might be a bug in existing code. > > sandeep samudrala wrote: > decorateEntityWithACL checks for the same? doesn't it? This line is in method decorateEntityWithACL - Balu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37837/#review96721 ----------------------------------------------------------- On Aug. 27, 2015, 11:30 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37837/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:30 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Currently to keep ACL backward compatible when we submit an entity without ACL tag then falcon automatically adds ACL to the entity definition. The same is done during update also, however it is omitted during touch command > > > Diffs > ----- > > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 5b415a2 > > Diff: https://reviews.apache.org/r/37837/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > > --===============1026951717416905180==--