Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0EB321722A for ; Thu, 20 Aug 2015 05:51:29 +0000 (UTC) Received: (qmail 84138 invoked by uid 500); 20 Aug 2015 05:51:28 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 84089 invoked by uid 500); 20 Aug 2015 05:51:28 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 84076 invoked by uid 99); 20 Aug 2015 05:51:28 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2015 05:51:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 29002DF673 for ; Thu, 20 Aug 2015 05:51:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.426 X-Spam-Level: *** X-Spam-Status: No, score=3.426 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.555] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 7iIoGYVYMRVz for ; Thu, 20 Aug 2015 05:51:26 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 398C221381 for ; Thu, 20 Aug 2015 05:51:25 +0000 (UTC) Received: (qmail 84067 invoked by uid 99); 20 Aug 2015 05:51:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2015 05:51:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E7F48F2335; Thu, 20 Aug 2015 05:51:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9192161605248822902==" MIME-Version: 1.0 Subject: Re: Review Request 37527: FALCON-1203: 2 validateACL UTs broken From: "Narayan Periwal" To: "Falcon" , "Narayan Periwal" Date: Thu, 20 Aug 2015 05:51:23 -0000 Message-ID: <20150820055123.12426.52222@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Narayan Periwal" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37527/ X-Sender: "Narayan Periwal" References: <20150817115314.2928.45417@reviews.apache.org> In-Reply-To: <20150817115314.2928.45417@reviews.apache.org> Reply-To: "Narayan Periwal" X-ReviewRequest-Repository: falcon-git --===============9192161605248822902== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37527/ ----------------------------------------------------------- (Updated Aug. 20, 2015, 5:51 a.m.) Review request for Falcon. Repository: falcon-git Description ------- The following UTs fail in falcon-common: FeedEntityParserTest.testValidateACLAndStorageForValidGroupBadOwner FeedEntityParserTest.testValidateACLValidGroupBadOwner Diffs (updated) ----- common/pom.xml 36de1f5 common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java cf5a9b4 common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java 8b81a29 common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java 11e2df2 common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java 675fd46 common/src/test/java/org/apache/falcon/entity/store/FeedLocationStoreTest.java 4c4b7f3 common/src/test/java/org/apache/falcon/hadoop/HadoopClientFactoryTest.java 1cb08ac common/src/test/java/org/apache/falcon/security/AuthenticationInitializationServiceTest.java 9b76a61 common/src/test/java/org/apache/falcon/security/CurrentUserTest.java 9a3f365 common/src/test/java/org/apache/falcon/security/DefaultAuthorizationProviderTest.java 162be12 common/src/test/java/org/apache/falcon/security/SecurityUtilTest.java 6e77462 common/src/test/java/org/apache/falcon/util/FalconTestUtil.java PRE-CREATION common/src/test/resources/config/cluster/cluster-no-registry.xml 86ee02d common/src/test/resources/config/feed/feed-0.1.xml f8518c5 common/src/test/resources/config/feed/feed-0.2.xml 8bf7d20 common/src/test/resources/config/feed/feed-tags-0.1.xml 8429f61 common/src/test/resources/config/feed/hive-table-feed-out.xml 17eb954 common/src/test/resources/config/feed/hive-table-feed.xml 67b3f4e common/src/test/resources/config/feed/invalid-feed.xml b7273a9 common/src/test/resources/config/feed/table-with-multiple-sources-feed.xml f84f3d4 common/src/test/resources/config/process/process-table.xml bcaf28e messaging/pom.xml b222c35 messaging/src/test/java/org/apache/falcon/messaging/FeedProducerTest.java 8f9d227 messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 9d49b25 messaging/src/test/java/org/apache/falcon/messaging/JMSMessageProducerTest.java 2d27ce3 messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java 77274ef oozie/pom.xml 4271bd4 oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 2f7787d oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 3aaf304 oozie/src/test/java/org/apache/falcon/oozie/workflow/FalconPostProcessingTest.java 0a9aaa0 oozie/src/test/resources/config/feed/feed-0.1.xml fb9b707 oozie/src/test/resources/config/feed/hive-table-feed-out.xml bd93a01 oozie/src/test/resources/config/feed/hive-table-feed.xml 66d0742 oozie/src/test/resources/config/late/late-feed1.xml c500c4c oozie/src/test/resources/config/late/late-feed2.xml 6ccffe2 oozie/src/test/resources/config/late/late-feed3.xml 239f140 oozie/src/test/resources/feed/feed.xml baa8f26 oozie/src/test/resources/feed/table-replication-feed.xml 4c610f6 prism/pom.xml 52b558d prism/src/test/java/org/apache/falcon/plugin/ChainableMonitoringPluginTest.java a0f6a81 prism/src/test/java/org/apache/falcon/security/FalconAuditFilterTest.java 0022451 prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 9e8c76a prism/src/test/java/org/apache/falcon/security/FalconAuthorizationFilterTest.java 27b64e9 rerun/pom.xml 2487aea rerun/src/test/java/org/apache/falcon/rerun/queue/ActiveMQTest.java 6b6b834 rerun/src/test/java/org/apache/falcon/rerun/queue/InMemoryQueueTest.java 8508d37 rerun/src/test/resources/feed-template.xml c3f2834 src/main/examples/entity/filesystem/in-feed.xml 4c433cb src/main/examples/entity/filesystem/out-feed.xml 4275df8 src/main/examples/entity/filesystem/replication-feed.xml ccf5cca src/main/examples/entity/hcat/hcat-in-feed.xml 5b2c998 src/main/examples/entity/hcat/hcat-out-feed.xml befd88f src/main/examples/entity/hcat/hcat-replication-feed.xml 2b43d28 Diff: https://reviews.apache.org/r/37527/diff/ Testing ------- Done Thanks, Narayan Periwal --===============9192161605248822902==--