Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DFFF918A51 for ; Thu, 13 Aug 2015 17:52:02 +0000 (UTC) Received: (qmail 65670 invoked by uid 500); 13 Aug 2015 17:52:02 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 65627 invoked by uid 500); 13 Aug 2015 17:52:02 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 65616 invoked by uid 99); 13 Aug 2015 17:52:02 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Aug 2015 17:52:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DFA99DD8A3 for ; Thu, 13 Aug 2015 17:52:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.974 X-Spam-Level: *** X-Spam-Status: No, score=3.974 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.006] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id DULIhVPGV69o for ; Thu, 13 Aug 2015 17:51:51 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id A43F5252C2 for ; Thu, 13 Aug 2015 16:53:44 +0000 (UTC) Received: (qmail 84226 invoked by uid 99); 13 Aug 2015 16:53:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Aug 2015 16:53:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E282D73ED9; Thu, 13 Aug 2015 16:53:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3933736938304938752==" MIME-Version: 1.0 Subject: Re: Review Request 37286: [FALCON-1382] Add a test for feed retention to make sure that data directory is not deleted From: "Raghav Gautam" To: "Paul Isaychuk" , "Raghav Gautam" , "Falcon" Date: Thu, 13 Aug 2015 16:53:41 -0000 Message-ID: <20150813165341.30461.33857@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Raghav Gautam" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37286/ X-Sender: "Raghav Gautam" References: <20150813133151.1374.26269@reviews.apache.org> In-Reply-To: <20150813133151.1374.26269@reviews.apache.org> Reply-To: "Raghav Gautam" X-ReviewRequest-Repository: falcon-git --===============3933736938304938752== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37286/#review95278 ----------------------------------------------------------- Ship it! Ship It! - Raghav Gautam On Aug. 13, 2015, 6:31 a.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37286/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 6:31 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1382 > https://issues.apache.org/jira/browse/FALCON-1382 > > > Repository: falcon-git > > > Description > ------- > > We want to add a feed retention test that leads to deletion of all the data. We want to make sure that the directory which contains the data is not deleted. for eg if the data looks like: > /tmp/data/2015-04-01 > /tmp/data/2015-04-02 > /tmp/data/2015-04-03 > And the retention operation deletes all the data then we want to make sure that /tmp/data does not get deleted. > > > Diffs > ----- > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java 628dca1 > > Diff: https://reviews.apache.org/r/37286/diff/ > > > Testing > ------- > > Tested on local VM cluster > > > Thanks, > > Paul Isaychuk > > --===============3933736938304938752==--