Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E70EF187A4 for ; Sat, 1 Aug 2015 07:39:04 +0000 (UTC) Received: (qmail 2337 invoked by uid 500); 1 Aug 2015 07:39:04 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 2295 invoked by uid 500); 1 Aug 2015 07:39:04 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 2281 invoked by uid 99); 1 Aug 2015 07:39:04 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Aug 2015 07:39:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 23DC31A946D for ; Sat, 1 Aug 2015 07:39:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.422 X-Spam-Level: ***** X-Spam-Status: No, score=5.422 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id XmLCWEvgJUZ5 for ; Sat, 1 Aug 2015 07:39:03 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 6F9264C0EA for ; Sat, 1 Aug 2015 07:39:02 +0000 (UTC) Received: (qmail 2267 invoked by uid 99); 1 Aug 2015 07:39:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Aug 2015 07:39:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B615A1C0552; Sat, 1 Aug 2015 07:39:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6184784131307623547==" MIME-Version: 1.0 Subject: Re: Review Request 36655: Add entity lineage test From: "PRAGYA MITTAL" To: "pavan kumar kolamuri" , "Falcon" , "PRAGYA MITTAL" Date: Sat, 01 Aug 2015 07:39:00 -0000 Message-ID: <20150801073900.1539.64995@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "PRAGYA MITTAL" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36655/ X-Sender: "PRAGYA MITTAL" References: <20150722123246.10541.43952@reviews.apache.org> In-Reply-To: <20150722123246.10541.43952@reviews.apache.org> Reply-To: "PRAGYA MITTAL" X-ReviewRequest-Repository: falcon-git --===============6184784131307623547== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 22, 2015, 12:32 p.m., pavan kumar kolamuri wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java, line 85 > > > > > > As it is utility it should be public and functionality of this method is same as matchlist , names should be same . If possible try to write a generic function which handle both string and Edge. Removed the function and added set based comparison. - PRAGYA ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36655/#review92583 ----------------------------------------------------------- On July 21, 2015, 8:50 p.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36655/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 8:50 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1321 > https://issues.apache.org/jira/browse/FALCON-1321 > > > Repository: falcon-git > > > Description > ------- > > Add entity lineage test with failed and passed scenarios. Related to https://issues.apache.org/jira/browse/FALCON-256 > > > Diffs > ----- > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java ae5c70c > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 50d7439 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java 175bb98 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java PRE-CREATION > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java c220215 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java b2e38b2 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntityLineageTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/36655/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > PRAGYA MITTAL > > --===============6184784131307623547==--