falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Re: Review Request 37748: Ability to disable oozie dryrun while scheduling or updating the falcon entity
Date Tue, 25 Aug 2015 14:27:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37748/#review96335
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java (line 64)
<https://reviews.apache.org/r/37748/#comment151648>

    Exactly - I tried coding dryrun method without the skipDryRun option, and code looked
repetitive in other methods


- Balu Vellanki


On Aug. 25, 2015, 6:30 a.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37748/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 6:30 a.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1174
>     https://issues.apache.org/jira/browse/FALCON-1174
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This patch has ability to disable dryrun by
> - setting falcon.skip.dryrun=true to disable dryrun for all entity schedule actions
> - CLI/RestAPI param -skipDryRun to disable dryrun for a single entity.
> The patch also has integration tests and was tested end2end.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 11f6bff 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java bb6d8c9 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java d9bdf64 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
07fafb5 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 2f3dc6f

>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java f2f9826 
>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
e38749a 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
d22e8a3 
>   prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java be1fe1f 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java e898fc3 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 9f00d94 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 57b7b1b 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 3bd625c 
>   webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java a2af0cd

>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java e328d69 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java c602ffb

>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 7b227b3 
> 
> Diff: https://reviews.apache.org/r/37748/diff/
> 
> 
> Testing
> -------
> 
> End 2 end testing done
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message