falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 37569: FALCON-1403: Revisit IT cleanup and teardown
Date Wed, 19 Aug 2015 07:11:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37569/#review95836
-----------------------------------------------------------



webapp/src/test/java/org/apache/falcon/process/TableStorageProcessIT.java (line 137)
<https://reviews.apache.org/r/37569/#comment150990>

    Since you are deleting all entities from store, there won't be a need for deleting them
individually, please remove these lines.


- Pallavi Rao


On Aug. 18, 2015, 7:01 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37569/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 7:01 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Currently in many of the integration tests such as FalconCLIIT, FalconCLISmokeIT, etc..
there is not cleanup happening after the testcase runs; this leads to many entities getting
accumulated in memory, which in turn leads to tests failing due to out of memory error
> 
> 
> Diffs
> -----
> 
>   webapp/src/test/java/org/apache/falcon/catalog/CatalogPartitionHandlerIT.java c7b7d3b

>   webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java 5faf5b5 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java e328d69 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java 7c1a42e 
>   webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java ed85db0 
>   webapp/src/test/java/org/apache/falcon/lifecycle/FileSystemFeedReplicationIT.java d7f36da

>   webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java 2a14ae4

>   webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedReplicationIT.java
13bc480 
>   webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 575b870 
>   webapp/src/test/java/org/apache/falcon/process/TableStorageProcessIT.java 2e882ea 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java c602ffb

>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java d4a1d8a

>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerPaginationJerseyIT.java
fd78b4b 
>   webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java eb1dda8

>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e

>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 7b227b3 
>   webapp/src/test/java/org/apache/falcon/validation/ClusterEntityValidationIT.java 431d334

>   webapp/src/test/java/org/apache/falcon/validation/FeedEntityValidationIT.java f6d941c

> 
> Diff: https://reviews.apache.org/r/37569/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message