falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "PRAGYA MITTAL" <mittal.pragy...@gmail.com>
Subject Re: Review Request 37313: Add Instance Dependency API Test
Date Tue, 18 Aug 2015 09:08:39 GMT


> On Aug. 13, 2015, 2:47 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java,
line 59
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036578#file1036578line59>
> >
> >     should it be private?

Seems private. Will change it.


> On Aug. 13, 2015, 2:47 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java,
line 460
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036572#file1036572line460>
> >
> >     assertNotNull can be used here.

Sure.


> On Aug. 13, 2015, 2:47 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java,
line 27
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036570#file1036570line27>
> >
> >     some name like PROCESS_INVALID_RANGE and FEED_INVALID_RANGE instead of unparsable?

Sure.


- PRAGYA


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review95255
-----------------------------------------------------------


On Aug. 10, 2015, 7:40 p.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 7:40 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1387
>     https://issues.apache.org/jira/browse/FALCON-1387
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java
85f3692 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java
2baa35f 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java
f984457 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java
4550666 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java
c68dd3c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java
f327178 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java
c5dd0fd 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java
6c8d4ee 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37313/diff/
> 
> 
> Testing
> -------
> 
> Tested.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message