falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 37444: CrossEntityValidations contains incorrect validations
Date Fri, 14 Aug 2015 01:53:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37444/#review95368
-----------------------------------------------------------

Ship it!


Ship It!

- Ajay Yadava


On Aug. 13, 2015, 8:27 p.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37444/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 8:27 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: Falcon-1398
>     https://issues.apache.org/jira/browse/Falcon-1398
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> (instEnd.after(feedEnd)) validation is applied twice for different error messages in
CrossEntityValidations.java
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/parser/CrossEntityValidations.java 7a01d1e

>   common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java 8783081

> 
> Diff: https://reviews.apache.org/r/37444/diff/
> 
> 
> Testing
> -------
> 
> Unit test added
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message