falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <rag...@apache.org>
Subject Re: Review Request 37288: [FALCON-1384] AbstractEntityHelper.java cleanup
Date Mon, 10 Aug 2015 16:41:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37288/#review94754
-----------------------------------------------------------

Ship it!


Ship It!

- Raghav Gautam


On Aug. 10, 2015, 2:27 a.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37288/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 2:27 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1384
>     https://issues.apache.org/jira/browse/FALCON-1384
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As of now the class has many fields with different access levels(privated, protected,
public etc). We want have a uniform pattern to the extent possible.
> Also, the file is a jumble of variables and methods - can we reorganize to make it more
readable.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java
2baa35f 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java
7157111 
> 
> Diff: https://reviews.apache.org/r/37288/diff/
> 
> 
> Testing
> -------
> 
> ran FeedResumeTest as test
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message