falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 37138: FALCON-1368: Changes to make configuration store loading parallel.
Date Thu, 06 Aug 2015 00:55:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37138/#review94334
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java (line 182)
<https://reviews.apache.org/r/37138/#comment148903>

    It will be a good idea to log if all tasks completed or time out occurred (returned by
the awaitTermination)


- Ajay Yadava


On Aug. 5, 2015, 7:42 p.m., sandeep samudrala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37138/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 7:42 p.m.)
> 
> 
> Review request for Falcon, Ajay Yadava and Srikanth Sundarrajan.
> 
> 
> Bugs: FALCON-1368
>     https://issues.apache.org/jira/browse/FALCON-1368
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> I have made changes to make configuration store loading of entities parallel for each
entity type in the respective order ( CLUSTER, FEED, PROCESS)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java 7b53ebb

> 
> Diff: https://reviews.apache.org/r/37138/diff/
> 
> 
> Testing
> -------
> 
> This is a sample of how it looks and there is a good dip in the restart time of falcon
server.
> 
> 2015-08-06 00:59:04,687 INFO  - [pool-5-thread-95:] ~ Restored configuration FEED/ipfeed34

> 2015-08-06 00:59:04,690 INFO  - [pool-5-thread-94:] ~ Restored configuration FEED/ipfeed18

> 2015-08-06 00:59:04,694 INFO  - [pool-5-thread-93:] ~ Restored configuration FEED/ipfeed10
> 
> 
> Thanks,
> 
> sandeep samudrala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message