falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "PRAGYA MITTAL" <mittal.pragy...@gmail.com>
Subject Re: Review Request 36655: Add entity lineage test
Date Mon, 03 Aug 2015 09:23:40 GMT


> On Aug. 1, 2015, 9:57 a.m., pavan kumar kolamuri wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java,
line 664
> > <https://reviews.apache.org/r/36655/diff/2/?file=1027088#file1027088line664>
> >
> >     Make this method to only add input feeds and output feeds and reset input feeds
can be called directly.

Added generic method for input and output feeds.


> On Aug. 1, 2015, 9:57 a.m., pavan kumar kolamuri wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java,
line 37
> > <https://reviews.apache.org/r/36655/diff/2/?file=1027091#file1027091line37>
> >
> >     Declare as local variables to the method

Done


- PRAGYA


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36655/#review93840
-----------------------------------------------------------


On Aug. 1, 2015, 7:55 a.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36655/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2015, 7:55 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1321
>     https://issues.apache.org/jira/browse/FALCON-1321
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add entity lineage test with failed and passed scenarios. Related to https://issues.apache.org/jira/browse/FALCON-256
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java
ae5c70c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java
50d7439 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java
175bb98 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java
PRE-CREATION 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java
c220215 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java
b2e38b2 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntityLineageTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36655/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message