Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 23DDD187A5 for ; Mon, 27 Jul 2015 05:10:47 +0000 (UTC) Received: (qmail 63872 invoked by uid 500); 27 Jul 2015 05:10:43 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 63825 invoked by uid 500); 27 Jul 2015 05:10:43 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 63812 invoked by uid 99); 27 Jul 2015 05:10:43 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jul 2015 05:10:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 021A51A79C3 for ; Mon, 27 Jul 2015 05:10:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.971 X-Spam-Level: *** X-Spam-Status: No, score=3.971 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id jHRsqYoEeJUt for ; Mon, 27 Jul 2015 05:10:41 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 8AD2524DB5 for ; Mon, 27 Jul 2015 05:10:40 +0000 (UTC) Received: (qmail 63742 invoked by uid 99); 27 Jul 2015 05:10:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jul 2015 05:10:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 279161CF88E; Mon, 27 Jul 2015 05:10:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4834475444509932377==" MIME-Version: 1.0 Subject: Re: Review Request 36812: FALCON-1329 Falcon idempotent behaviour breaks in some cases From: "Pallavi Rao" To: "Ajay Yadava" , "Falcon" , "Pallavi Rao" Date: Mon, 27 Jul 2015 05:10:39 -0000 Message-ID: <20150727051039.28760.63871@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Pallavi Rao" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36812/ X-Sender: "Pallavi Rao" References: <20150725114744.1578.29347@reviews.apache.org> In-Reply-To: <20150725114744.1578.29347@reviews.apache.org> Reply-To: "Pallavi Rao" X-ReviewRequest-Repository: falcon-git --===============4834475444509932377== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36812/#review93071 ----------------------------------------------------------- prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java (line 234) An exception used to get thrown in case there is a failure/partial success. So, in case of errors, the code doesn't even reach here. Now, we don't throw an exception on partial failures and additionally check for the success status. The additional status check is good. But, I don't understand how it addresses the issue. - Pallavi Rao On July 25, 2015, 11:47 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36812/ > ----------------------------------------------------------- > > (Updated July 25, 2015, 11:47 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1329 > https://issues.apache.org/jira/browse/FALCON-1329 > > > Repository: falcon-git > > > Description > ------- > > In certain cases Idempotent behaviour of falcon is broken. Sometimes, entities go in a zombie state. > > > Diffs > ----- > > prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 3d3a58a > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java eb281d3 > > Diff: https://reviews.apache.org/r/36812/diff/ > > > Testing > ------- > > Manually tested in distributed mode. Unit tests or integration tests for this are not possible. > > > Thanks, > > Ajay Yadava > > --===============4834475444509932377==--