falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 36655: Add entity lineage test
Date Wed, 22 Jul 2015 12:42:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36655/#review92587
-----------------------------------------------------------



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java
(line 39)
<https://reviews.apache.org/r/36655/#comment146785>

    Why is this required?



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java
(line 65)
<https://reviews.apache.org/r/36655/#comment146787>

    I think this can also be avoided.



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java
(line 85)
<https://reviews.apache.org/r/36655/#comment146786>

    You can achieve the same result by constructing set from the list and then doing a set
equality comparison.



falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java (line
29)
<https://reviews.apache.org/r/36655/#comment146788>

    rename to JSON_CONTENT_TYPE?


- Ajay Yadava


On July 21, 2015, 8:50 p.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36655/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 8:50 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1321
>     https://issues.apache.org/jira/browse/FALCON-1321
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add entity lineage test with failed and passed scenarios. Related to https://issues.apache.org/jira/browse/FALCON-256
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java
ae5c70c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java
50d7439 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java
175bb98 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java
PRE-CREATION 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java
c220215 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java
b2e38b2 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntityLineageTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36655/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message