falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Namit Maheshwari" <nmaheshw...@hortonworks.com>
Subject Re: Review Request 36555: falcon-1314: unify handling of local files and directory
Date Thu, 16 Jul 2015 20:49:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36555/#review91962
-----------------------------------------------------------

Ship it!


Ship It!

- Namit Maheshwari


On July 16, 2015, 8:37 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36555/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 8:37 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-1314
>     https://issues.apache.org/jira/browse/falcon-1314
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> falcon-1314: unify handling of local files and directory
> 
> As of now, the code relies on 
> 1. string concatenation for joining paths for local files & directories
> 2. which in turn assumes that folder path will have / at end
> 3. at places it uses hard coded "/" for separators
> 
> This is not ok in windows environment. This patch addresses these issues.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java
2a5566a9c7154ed33f9e3a0ba053fc1956092174 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/LogUtil.java
b03a13b1ac5d497218f08849748d7533e5538c76 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java
d1f1c249a1b35082d0bcf2e93d3118cd0dbeb119 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java
0c24f7e03d8916f098582d5c972bc9bdeaf260a5 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java
87fab7cca1dad95677941345f94ea725447ae687 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
d3370b461670459960e02858d2c42f2d4354eb17 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java
a7a2ea8e2b270295777475ab34555b3a7fe82c59 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/LogMoverTest.java
5398581d557ff709b77bd85b3662620744c37ee2 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java
081938f5aa8e31697ba7434a0bae4e52688c9430 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java
61c076ba27fe1cc1b26343aadd970c457315b42a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java
ef3d8a77c9fafe9be032a070810faa63acdda7d6 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
aa9bdd5c4aa0969c1bc930c28143f79f8674cb81 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathLoadTest.java
d4da519c3b22da356fc3a7f33b98b96733f99bd5 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java
dc2fc37ff400b4b18d9fcea4bd3e164eb51e60ec 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java
277dff5725028da32c0e10f8f0d8c432bdba2df8 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatProcessTest.java
03e179787616fc0e6688b7aa8e85fd13fb49ae36 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatReplicationTest.java
59a2077f1618479cf0a56c09d9045843f17b530d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayTest.java
22aabfa065c3981c520f68307b18e38b964a3277 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedLateReplicationTest.java
1bc4027bde66094fcfcffb3d314cce05295078d5 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java
43aafdf9ba0e426d936471fd01d7597961bd6a04 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java
5e868e2c260aa76847bf04392f6f5f4b850177e9 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java
819438fce31f85b11f0e82b5da36f34649ed33cc 
> 
> Diff: https://reviews.apache.org/r/36555/diff/
> 
> 
> Testing
> -------
> 
> EmbeddedPigScriptTest
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message