Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A2DB717F66 for ; Fri, 5 Jun 2015 06:58:36 +0000 (UTC) Received: (qmail 45803 invoked by uid 500); 5 Jun 2015 06:58:34 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 45764 invoked by uid 500); 5 Jun 2015 06:58:34 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 45429 invoked by uid 99); 5 Jun 2015 06:58:33 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2015 06:58:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6FE3BC08D9 for ; Fri, 5 Jun 2015 06:58:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.172 X-Spam-Level: ***** X-Spam-Status: No, score=5.172 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Nw0on391UbKB for ; Fri, 5 Jun 2015 06:58:32 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 2B2E4428E3 for ; Fri, 5 Jun 2015 06:58:32 +0000 (UTC) Received: (qmail 43669 invoked by uid 99); 5 Jun 2015 06:58:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2015 06:58:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2C9C31C0697; Fri, 5 Jun 2015 06:58:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5725809831753637859==" MIME-Version: 1.0 Subject: Re: Review Request 35057: FALCON-796 Enable users to triage data processing issues through falcon From: "Ajay Yadava" To: "Srikanth Sundarrajan" Cc: "Scott Preece" , "Falcon" , "Ajay Yadava" Date: Fri, 05 Jun 2015 06:58:31 -0000 Message-ID: <20150605065831.7996.22596@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ajay Yadava" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/35057/ X-Sender: "Ajay Yadava" References: <20150604091140.7996.8587@reviews.apache.org> In-Reply-To: <20150604091140.7996.8587@reviews.apache.org> Reply-To: "Ajay Yadava" X-ReviewRequest-Repository: falcon-git --===============5725809831753637859== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35057/ ----------------------------------------------------------- (Updated June 5, 2015, 6:58 a.m.) Review request for Falcon and Srikanth Sundarrajan. Changes ------- Implemented the code review comments from Scott and Srikanth. Bugs: FALCON-796 https://issues.apache.org/jira/browse/FALCON-796 Repository: falcon-git Description ------- Enable users to triage data processing issues through falcon Diffs (updated) ----- client/src/main/java/org/apache/falcon/ResponseHelper.java 78598ba client/src/main/java/org/apache/falcon/cli/FalconCLI.java f169917 client/src/main/java/org/apache/falcon/client/FalconClient.java 20c32e4 client/src/main/java/org/apache/falcon/resource/TriageResult.java PRE-CREATION docs/src/site/twiki/FalconCLI.twiki 50dce84 docs/src/site/twiki/restapi/ResourceList.twiki 49dddb7 docs/src/site/twiki/restapi/Triage.twiki PRE-CREATION prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 72f9fe4 prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 1a8396c webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java c2ac5b2 Diff: https://reviews.apache.org/r/35057/diff/ Testing ------- Tests are there and tested by deploying locally as well. Thanks, Ajay Yadava --===============5725809831753637859==--