falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suhas Vasu" <suhas....@gmail.com>
Subject Re: Review Request 35596: FALCON-1186-Add filtering capability to result of instance summary & FALCON-1208-Falcon instance APIs cannot filter on more than one value for a given field
Date Mon, 29 Jun 2015 12:49:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35596/
-----------------------------------------------------------

(Updated June 29, 2015, 12:49 p.m.)


Review request for Falcon.


Changes
-------

Adding updated patch due to merge conflicts. Please review :)


Repository: falcon-git


Description
-------

1) Falcon instance summary returns a consolidated instance summary of all instances between
the specified time range.
   It would be helpful to add filtering capability on this result.
   For ex:- Give me all killed instances for a particular time range or Give me all succeeded
instances for a time range
   This would be really helpful when someone wants to use falcon client methods / API's to
do some monitoring on the process instances

2) Say I want to run falcon instance status command and i want to filter by RUNNING &
KILLED instances.
   This would be done by issuing - -filterBy Status:SUCCEEDED,Status:KILLED
   In the server, we use a hashmap, because of which only one entry for Status will be retained
and as a result the resultset will be filtered only by the last filter.
   We should use a data-structure that allows duplicate values for the same key.


Diffs (updated)
-----

  client/src/main/java/org/apache/falcon/cli/FalconCLI.java cc041c0 
  client/src/main/java/org/apache/falcon/client/FalconClient.java 5df8626 
  client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java a3dcbe4 
  docs/src/site/twiki/FalconCLI.twiki aeab8f8 
  docs/src/site/twiki/restapi/InstanceSummary.twiki 9d1041e 
  prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java a721666 
  prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 13e0c82 
  prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 95e0e69

  prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 0d59c22 
  webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java 7249ba4 

Diff: https://reviews.apache.org/r/35596/diff/


Testing
-------

All UT's have run successfully
Also have manually run a pipeline and tested the features incorporated


Thanks,

Suhas  Vasu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message