falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 35452: FALCON-1260 InstanceDependency API gives incorrect results.
Date Mon, 29 Jun 2015 06:53:19 GMT


> On June 26, 2015, 8:21 a.m., Srikanth Sundarrajan wrote:
> > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java, line 183
> > <https://reviews.apache.org/r/35452/diff/1/?file=984614#file984614line183>
> >
> >     Does it make sense to assert on the actual values besides the size of the set.
Also see if other such asserts introduced by the patch can be changed.

Absolutely. Will make the necessary changes.


> On June 26, 2015, 8:21 a.m., Srikanth Sundarrajan wrote:
> > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java,
line 392
> > <https://reviews.apache.org/r/35452/diff/1/?file=984618#file984618line392>
> >
> >     Though not an issue caused by this patch, there seems to be no logging of the
actual exception. It would be useful to log the full exception since we aren't passing it
up.

Thanks for surfacing it. Will add logging.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35452/#review88027
-----------------------------------------------------------


On June 15, 2015, 10:57 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35452/
> -----------------------------------------------------------
> 
> (Updated June 15, 2015, 10:57 a.m.)
> 
> 
> Review request for Falcon and Srikanth Sundarrajan.
> 
> 
> Bugs: FALCON-1260
>     https://issues.apache.org/jira/browse/FALCON-1260
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> There were some bugs in the current implementation.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java 2a7ecdb

>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java 7ebf39e 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 9f4eb61 
>   common/src/main/java/org/apache/falcon/entity/ProcessHelper.java fe78bc8 
>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java f70edfb 
>   common/src/test/java/org/apache/falcon/entity/ProcessHelperTest.java 0d396ae 
>   docs/src/site/twiki/FalconCLI.twiki 50dce84 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 72f9fe4

>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 1a8396c

> 
> Diff: https://reviews.apache.org/r/35452/diff/
> 
> 
> Testing
> -------
> 
> Unit tests added for all the issues and tests were also added for newer scenarios.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message