falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Review Request 35398: Falcon 1271 - Throw useful exception when workflow/coordinator/bundle file path is > 255 chars
Date Fri, 12 Jun 2015 18:42:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35398/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1271
    https://issues.apache.org/jira/browse/FALCON-1271


Repository: falcon-git


Description
-------

Falcon uses Oozie as its workflow engine and Oozie has a 255 char limit on the length of path
of workflow/coordinator/bundle files. This limit occurs because oozie stores the path in a
OpenJPA database which has 255 char limit for this column.
Instead of failing with a hard to understand error during run time, it makes sense for Falcon
to check the length of path and throw a more useful exception when an entity is scheduled.
I propose adding a property to runtime.properties. This way, when Oozie changes the limit,
falcon can update limit without code changes


Diffs
-----

  common/src/main/resources/runtime.properties 8d465e8 
  oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java f00290e 
  oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java b223447

  src/conf/runtime.properties a40d369 

Diff: https://reviews.apache.org/r/35398/diff/


Testing
-------

Unit test added, and it passed.


Thanks,

Balu Vellanki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message