falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 35058: FALCON-1038: Log mover fails for map-reduce action
Date Wed, 10 Jun 2015 07:52:33 GMT


> On June 8, 2015, 4:36 a.m., Pallavi Rao wrote:
> > Ship It!

Thanks Pallavi for review.


> On June 8, 2015, 4:36 a.m., Pallavi Rao wrote:
> > oozie/src/main/java/org/apache/falcon/logging/JobLogMover.java, line 155
> > <https://reviews.apache.org/r/35058/diff/2/?file=978948#file978948line155>
> >
> >     Nit : method name, isSupportedActionType, is more appropriate as the method
returns a boolean.

Added isActionTypeSupported.


- Peeyush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35058/#review86983
-----------------------------------------------------------


On June 10, 2015, 6:46 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35058/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 6:46 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1038
>     https://issues.apache.org/jira/browse/FALCON-1038
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Log mover fails for map-reduce action
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/logging/DefaultTaskLogRetriever.java 962f891

>   oozie/src/main/java/org/apache/falcon/logging/JobLogMover.java ba669c8 
>   oozie/src/main/java/org/apache/falcon/logging/TaskLogRetrieverYarn.java 61c5afb 
> 
> Diff: https://reviews.apache.org/r/35058/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message