falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 35058: FALCON-1038: Log mover fails for map-reduce action
Date Mon, 08 Jun 2015 06:26:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35058/#review86986
-----------------------------------------------------------



oozie/src/main/java/org/apache/falcon/logging/JobLogMover.java
<https://reviews.apache.org/r/35058/#comment139199>

    With this change logs api in falcon might fail . Can you please check whether that is
working after this change ? Mostly it won't fail can you please check on safer side.



oozie/src/main/java/org/apache/falcon/logging/TaskLogRetrieverYarn.java
<https://reviews.apache.org/r/35058/#comment139196>

    Can we also check whether YARN_LOG_SERVER_URL  property was set or not ? Else we should
log the message . Otherwise it leads to null pointer exception and user might not understand
until he looks into code. Please correct me if there is always default value for this .


- pavan kumar kolamuri


On June 4, 2015, 9:19 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35058/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 9:19 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1038
>     https://issues.apache.org/jira/browse/FALCON-1038
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Log mover fails for map-reduce action
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/logging/DefaultTaskLogRetriever.java 962f891

>   oozie/src/main/java/org/apache/falcon/logging/JobLogMover.java ba669c8 
>   oozie/src/main/java/org/apache/falcon/logging/TaskLogRetrieverYarn.java 61c5afb 
> 
> Diff: https://reviews.apache.org/r/35058/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message