Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E7AC0180EC for ; Wed, 20 May 2015 01:52:32 +0000 (UTC) Received: (qmail 12950 invoked by uid 500); 20 May 2015 01:52:32 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 12906 invoked by uid 500); 20 May 2015 01:52:32 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 12895 invoked by uid 99); 20 May 2015 01:52:32 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 May 2015 01:52:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 27EA21A2FF5 for ; Wed, 20 May 2015 01:52:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.221 X-Spam-Level: **** X-Spam-Status: No, score=4.221 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id nQleKhlgO2-O for ; Wed, 20 May 2015 01:52:30 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 5E00143DAB for ; Wed, 20 May 2015 01:52:30 +0000 (UTC) Received: (qmail 12797 invoked by uid 99); 20 May 2015 01:52:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 May 2015 01:52:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D89331DD54A; Wed, 20 May 2015 01:52:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1970418551748648057==" MIME-Version: 1.0 Subject: Re: Review Request 34240: Feed Wizard multiple tests From: "Namit Maheshwari" To: "Namit Maheshwari" , "Raghav Gautam" , "Falcon" Date: Wed, 20 May 2015 01:52:28 -0000 Message-ID: <20150520015228.14201.18809@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Namit Maheshwari" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/34240/ X-Sender: "Namit Maheshwari" References: <20150520004638.14201.49209@reviews.apache.org> In-Reply-To: <20150520004638.14201.49209@reviews.apache.org> Reply-To: "Namit Maheshwari" X-ReviewRequest-Repository: falcon-git --===============1970418551748648057== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 20, 2015, 12:46 a.m., Raghav Gautam wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java, line 134 > > > > > > please use java doc comments. > > > > /** > > ... doc here... > > */ All the review comments have been addressed. Please check now. - Namit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34240/#review84429 ----------------------------------------------------------- On May 20, 2015, 1:49 a.m., Namit Maheshwari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34240/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 1:49 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1222 > https://issues.apache.org/jira/browse/FALCON-1222 > > > Repository: falcon-git > > > Description > ------- > > Feed Wizard multiple tests > > > Diffs > ----- > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java e72ce6706d7fe3331744d723894193bfbaff586a > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java 6eed4cef86c1974c3d30f0133b34894e24ac1750 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java 8920f41129175a207ae6dee0659a514fef17bcfc > > Diff: https://reviews.apache.org/r/34240/diff/ > > > Testing > ------- > > Below new tests added. Tested the same. > testWizardCancel > testWizardXmlPreview > testGeneralStepEditXml > testGeneralStepDefaultScenario > testGeneralStepXmlPreview > testGeneralStepAddRemoveTag > testGeneralStepBlankOptionalFields > testTimingStepDefaultScenario > testTimingStepXmlPreview > testTimingStepEditXml > testTimingStepDropDownLists > testTimingStepAddDeleteProperties > testLocationStepValidValuesFS > testLocationStepValidCatalogStorage > testLocationStepBothLocationsAndTableUri > testLocationStepEditXml > testClustersStepDefaultScenario > testClustersStepDropDownLists > testClustersStepDefaultLocations > testClusterStepEditXml > testSummaryStepDefaultScenario > > > Thanks, > > Namit Maheshwari > > --===============1970418551748648057==--