Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8ADDB18D6C for ; Fri, 15 May 2015 04:32:42 +0000 (UTC) Received: (qmail 17350 invoked by uid 500); 15 May 2015 04:32:42 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 17301 invoked by uid 500); 15 May 2015 04:32:42 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 17284 invoked by uid 99); 15 May 2015 04:32:42 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 May 2015 04:32:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B5E49C1393 for ; Fri, 15 May 2015 04:32:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.172 X-Spam-Level: ***** X-Spam-Status: No, score=5.172 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id siW-u9i_GWQb for ; Fri, 15 May 2015 04:32:40 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id B768C20D6D for ; Fri, 15 May 2015 04:32:40 +0000 (UTC) Received: (qmail 17269 invoked by uid 99); 15 May 2015 04:32:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 May 2015 04:32:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 425011DD10C; Fri, 15 May 2015 04:32:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3074010262912275379==" MIME-Version: 1.0 Subject: Re: Review Request 33892: FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable From: "Peeyush Bishnoi" To: "Peeyush Bishnoi" , "Falcon" , "Ajay Yadava" Date: Fri, 15 May 2015 04:32:40 -0000 Message-ID: <20150515043240.1461.68164@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Peeyush Bishnoi" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/33892/ X-Sender: "Peeyush Bishnoi" References: <20150514090638.1460.95534@reviews.apache.org> In-Reply-To: <20150514090638.1460.95534@reviews.apache.org> Reply-To: "Peeyush Bishnoi" X-ReviewRequest-Repository: falcon-git --===============3074010262912275379== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 14, 2015, 9:06 a.m., Ajay Yadava wrote: > > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, line 195 > > > > > > I don't want to but I have to put another nit. toString() will not log the stacktrace. Since it is not logged at the lower level also, we will not know exactly why FS didn't get initialized. Already fixed it in the patch. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33892/#review83736 ----------------------------------------------------------- On May 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33892/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 8:58 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1165 > https://issues.apache.org/jira/browse/FALCON-1165 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable > > > Diffs > ----- > > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3 > > Diff: https://reviews.apache.org/r/33892/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Peeyush Bishnoi > > --===============3074010262912275379==--