falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <rag...@apache.org>
Subject Re: Review Request 34793: More Search UI tests
Date Fri, 29 May 2015 20:42:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34793/#review85802
-----------------------------------------------------------



falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java
<https://reviews.apache.org/r/34793/#comment137605>

    why has this been made public ? I think we were using this only within childs of AbstractSearchPage.
Is that no longer the case ?



falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java
<https://reviews.apache.org/r/34793/#comment137601>

    This method is used at only one place with true parameter. I think it can be inlined.


- Raghav Gautam


On May 28, 2015, 5:29 p.m., Namit Maheshwari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34793/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 5:29 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> More Search UI tests
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java
780cd0ce53f3e9507f9892ea75c8bb8938fc6f43 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java
300a3d63eca44e0c99a856e646dbb233def7e9fa 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java
c84cfe550c7c75ea808c23798a617df44ebc3c6d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java
b752a869c9ad70a4c24ff51a3350269b9e21be3e 
> 
> Diff: https://reviews.apache.org/r/34793/diff/
> 
> 
> Testing
> -------
> 
> Below new tests added:
> testUploadEntity
> testUploadBadEntity
> clusterSetupNameAvailability
> 
> Have tested them on local
> 
> 
> Thanks,
> 
> Namit Maheshwari
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message