falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ying Zheng" <yzh...@hortonworks.com>
Subject Re: Review Request 32946: Falcon-1121: Backend Support for Free-text Entity Search
Date Fri, 22 May 2015 15:49:00 GMT


> On May 10, 2015, 1:51 a.m., Srikanth Sundarrajan wrote:
> > Have shared my views on the API here. Haven't reviewed the rest of the patch
> > 
> > https://issues.apache.org/jira/browse/FALCON-1095?focusedCommentId=14536986#comment-14536986
> > 
> > Also can we drop the "schedulable" entityType and include a specific entity or include
all entities. (in which case we would make entityType optional for this api). Reason for suggesting
this is to avoid excluding clusters specifically when entitites are being searched.
> > 
> > Dont recall seeing any changes in the Authorization layer with respect to this change.
Are there any needed ?

Thank you for sharing your valuable thoughts!

Per our discussion offline, I updated the code to 1) Support comma-separated entity types:
e.g. api/entities/list/feed,process. The user can specify any combination of entity types
(e.g. feed+process, cluster+feed, etc.) in this way. 2) Make entity type optional in the REST
api, i.e. api/entities/list will return the entities of all types.

In consideration of backward compatibility, we still keep “tags” option, which matches
the full tag and is a subset of our current tag keyword search approach. We will clean up
this parameter (as well as name filter in filterBy option) in a follow-up JIRA for Falcon
1.0. The follow-up JIRA will handle with backward incompatibility due to the parameter cleanups.
https://issues.apache.org/jira/browse/FALCON-1235


- Ying


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32946/#review83174
-----------------------------------------------------------


On May 22, 2015, 3:39 p.m., Ying Zheng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32946/
> -----------------------------------------------------------
> 
> (Updated May 22, 2015, 3:39 p.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, Seetharam Venkatesh, and Venkat
Ranganathan.
> 
> 
> Bugs: Falcon-1121
>     https://issues.apache.org/jira/browse/Falcon-1121
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> See parent JIRA Falcon-1095 for detailed descriptions: http://issues.apache.org/jira/browse/Falcon-1095
> Four changes in total:
> 1. Added API support: return feeds and processes if :entity-type is set to schedulable;
change parameter for subsequence matching from "pattern" to "nameseq"; multi-keyword matching
for entity tags with parameter "tagkeys".
> 2. Added command line support.
> 3. Added unit tests.
> 4. Updated twiki.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 7d56b01 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java fedcea6 
>   client/src/main/java/org/apache/falcon/entity/v0/Entity.java 7fb271d 
>   client/src/main/java/org/apache/falcon/resource/EntityList.java 4c96195 
>   common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java b84371f

>   docs/src/site/twiki/FalconCLI.twiki 0e42ae2 
>   docs/src/site/twiki/restapi/EntityList.twiki 08dd304 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 25cb312 
>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
6198c74 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
2dcf779 
>   prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java 9b0dec5 
>   webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 82a622c

>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java dd14e9c 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java ee5534a 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 280253d

> 
> Diff: https://reviews.apache.org/r/32946/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed. Also tested command line and using api calls.
> 
> 
> Thanks,
> 
> Ying Zheng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message