falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 33892: FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
Date Fri, 15 May 2015 04:32:40 GMT


> On May 14, 2015, 9:06 a.m., Ajay Yadava wrote:
> > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java,
line 195
> > <https://reviews.apache.org/r/33892/diff/3/?file=958011#file958011line195>
> >
> >     I don't want to but I have to put another nit. toString() will not log the stacktrace.
Since it is not logged at the lower level also, we will not know exactly why FS didn't get
initialized.

Already fixed it in the patch.


- Peeyush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review83736
-----------------------------------------------------------


On May 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 8:58 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1165
>     https://issues.apache.org/jira/browse/FALCON-1165
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3

> 
> Diff: https://reviews.apache.org/r/33892/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message