falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Re: Review Request 34192: FALCON-1060 Handle transaction failures in Lineage
Date Thu, 14 May 2015 21:01:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34192/#review83835
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/metadata/MetadataMappingService.java
<https://reviews.apache.org/r/34192/#comment134915>

    Minor nit : Can you please catch NumberFormatException and throw a more readable FalconException.
Since you are using int and long, parseInt and parseLong might be better than valueOf.



common/src/main/java/org/apache/falcon/metadata/MetadataMappingService.java
<https://reviews.apache.org/r/34192/#comment134921>

    Perhaps we can add new method entityGraphBuilder.addEntity(Entity entity) which can then
call entityGraphBuilder.addClusterEntity or entityGraphBuilder.addFeedEntity etc based on
entity type.  If we do this, we can avoid switch statement and repetition of code for both
add and update scenarios.



common/src/main/java/org/apache/falcon/metadata/MetadataMappingService.java
<https://reviews.apache.org/r/34192/#comment134922>

    Similar suggestion as onAdd, perhaps you can create entityGraphBuilder.updateEntity method



common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java
<https://reviews.apache.org/r/34192/#comment134926>

    Can we add a test to simulate transactional failures and verify the rollback?  For example,
add a process entity with a non-existing input feed. This will fail with IllegalStateException("Feed
entity vertex must exist: " + feedName).
    
    Then verify that a vertex was not added for this process.


- Balu Vellanki


On May 14, 2015, 5:52 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34192/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 5:52 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Handle transaction failures in Lineage , Rolling back transactions if they are partial.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/metadata/EntityRelationshipGraphBuilder.java
d90f7ec 
>   common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java
2288443 
>   common/src/main/java/org/apache/falcon/metadata/MetadataMappingService.java 9137fe0

>   common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 11d27fe

>   pom.xml 47718ba 
> 
> Diff: https://reviews.apache.org/r/34192/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message