falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Isaychuk" <pisayc...@hortonworks.com>
Subject Re: Review Request 34067: ProcessSetupTest
Date Wed, 13 May 2015 16:50:53 GMT


> On May 13, 2015, 4:44 p.m., Paul Isaychuk wrote:
> > checkstyle violations
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java:157:9:
switch without "default" clause.
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java:44:
Missing a Javadoc comment.
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java:97:
First sentence should end with a period.
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java:20:8:
Unused import - org.apache.falcon.entity.v0.cluster.ClusterLocationType.
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java:21:8:
Unused import - org.apache.falcon.entity.v0.cluster.Interfaces.

my fail:) last 2 of them are from my code


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34067/#review83624
-----------------------------------------------------------


On May 12, 2015, 12:22 a.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34067/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 12:22 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-1210
>     https://issues.apache.org/jira/browse/falcon-1210
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> ProcessSetupTest
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java
eaaeba25307bf2f494d76cd5de080aadcbd6ce54 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewProcessPage.java
f7d5bade1a8e99e4804a94d27f9345d19335b6ca 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java
b9d766f722377cf36eb08a938f8f38b143021f28 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34067/diff/
> 
> 
> Testing
> -------
> 
> testGeneralStepDefaultScenario fails because entity with long names are not allowed
> testHeader passes
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message