falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 33892: FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
Date Fri, 08 May 2015 16:42:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review83007
-----------------------------------------------------------



oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment133885>

    From the way I see it you are passing another variable through both onAdd and onReload
to introduce a new control branch(catch exception in case of add or throw it in case of reload).
I am suggesting to let the addLibsTo always throw exception. If reload flow needs to continue
then let it catch the exception. This way you don't need to alter onAdd or addLibsTo and only
the onReload needs to change. Makes sense?


- Ajay Yadava


On May 8, 2015, 8:50 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 8:50 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1165
>     https://issues.apache.org/jira/browse/FALCON-1165
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3

> 
> Diff: https://reviews.apache.org/r/33892/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message