falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 33892: FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
Date Thu, 07 May 2015 04:48:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review82790
-----------------------------------------------------------



oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment133608>

    Using an instance variable to differentiate between add and reload will make it thread-unsafe.

    Add and reload may not happen simultaneously in this case, but, lets keep it thread safe,
anyway. You can achieve the same using method variables.
    
    You can add another private method:
    private addEntity(Entity entity, isReload){..}
    
    public onAdd(Entity entity) {
       addEntity(entity, false);
    }
    
    public onReload(Entity entity) {
       addEntity(entity, true);
    }



oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment133609>

    Don't think you need fsException variable at all. Using,
    if (!reloadEntity) {
       throw FalconException(...);
    }
    should do it. Isn't it?


- Pallavi Rao


On May 6, 2015, 12:47 p.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 12:47 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1165
>     https://issues.apache.org/jira/browse/FALCON-1165
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3

> 
> Diff: https://reviews.apache.org/r/33892/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message