Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1AB25174E0 for ; Thu, 23 Apr 2015 14:06:36 +0000 (UTC) Received: (qmail 33310 invoked by uid 500); 23 Apr 2015 14:06:36 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 33277 invoked by uid 500); 23 Apr 2015 14:06:36 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 33266 invoked by uid 99); 23 Apr 2015 14:06:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2015 14:06:35 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: message received from 54.76.25.247 which is an MX secondary for dev@falcon.apache.org) Received: from [54.76.25.247] (HELO mx1-eu-west.apache.org) (54.76.25.247) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2015 14:06:07 +0000 Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 1D7B7201E8 for ; Thu, 23 Apr 2015 14:06:05 +0000 (UTC) Received: (qmail 32997 invoked by uid 99); 23 Apr 2015 14:06:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2015 14:06:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3991A1CC15B; Thu, 23 Apr 2015 14:06:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2637815128860166200==" MIME-Version: 1.0 Subject: Re: Review Request 33396: [FALCON-1171] Adding tests for search API From: "Paul Isaychuk" To: "Raghav Gautam" , "Paul Isaychuk" , "Falcon" Date: Thu, 23 Apr 2015 14:06:06 -0000 Message-ID: <20150423140606.2947.80107@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Paul Isaychuk" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/33396/ X-Sender: "Paul Isaychuk" References: <20150422162028.2947.17953@reviews.apache.org> In-Reply-To: <20150422162028.2947.17953@reviews.apache.org> Reply-To: "Paul Isaychuk" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============2637815128860166200== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33396/ ----------------------------------------------------------- (Updated April 23, 2015, 2:06 p.m.) Review request for Falcon. Changes ------- 1) new 5 test cases 2) few existing test cases changed 3) both basic input and output feeds which don't have tags are taken into account 4) documentation added 5) migration from arrays to lists 6) SearchResult renamed into Result (it is contained by SearchApiTest, thus it's clear that it relates to search api:) 7) replace validations to Result class Both testing and checkstyle verfication done Bugs: FALCON-1171 https://issues.apache.org/jira/browse/FALCON-1171 Repository: falcon-git Description ------- Adding tests for search API Diffs (updated) ----- falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java b899f1a falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SearchApiTest.java PRE-CREATION falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java 3ae44e6 Diff: https://reviews.apache.org/r/33396/diff/ Testing ------- All tests pass Thanks, Paul Isaychuk --===============2637815128860166200==--