Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 054CD17F1E for ; Wed, 22 Apr 2015 22:57:51 +0000 (UTC) Received: (qmail 58710 invoked by uid 500); 22 Apr 2015 22:57:50 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 58670 invoked by uid 500); 22 Apr 2015 22:57:50 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 58659 invoked by uid 99); 22 Apr 2015 22:57:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2015 22:57:50 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: message received from 54.164.171.186 which is an MX secondary for dev@falcon.apache.org) Received: from [54.164.171.186] (HELO mx1-us-east.apache.org) (54.164.171.186) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2015 22:57:45 +0000 Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 71FB843CB6 for ; Wed, 22 Apr 2015 22:57:24 +0000 (UTC) Received: (qmail 57585 invoked by uid 99); 22 Apr 2015 22:57:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2015 22:57:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4ABD71DB62A; Wed, 22 Apr 2015 22:57:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6971040388704812749==" MIME-Version: 1.0 Subject: Re: Review Request 32946: Falcon-1121: Backend Support for Free-text Entity Search From: "Ying Zheng" To: "Venkat Ranganathan" , "Seetharam Venkatesh" , "Sowmya Ramesh" , "Ajay Yadava" Cc: "Ying Zheng" , "Scott Preece" , "Falcon" Date: Wed, 22 Apr 2015 22:57:25 -0000 Message-ID: <20150422225725.2948.81292@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ying Zheng" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/32946/ X-Sender: "Ying Zheng" References: <20150422223121.2947.22102@reviews.apache.org> In-Reply-To: <20150422223121.2947.22102@reviews.apache.org> Reply-To: "Ying Zheng" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============6971040388704812749== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 22, 2015, 10:31 p.m., Scott Preece wrote: > > docs/src/site/twiki/restapi/EntityList.twiki, line 32 > > > > > > "returning entities must" -> "returned entities will" Changed. - Ying ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32946/#review81229 ----------------------------------------------------------- On April 22, 2015, 10:50 p.m., Ying Zheng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32946/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 10:50 p.m.) > > > Review request for Falcon, Ajay Yadava, Sowmya Ramesh, Seetharam Venkatesh, and Venkat Ranganathan. > > > Bugs: Falcon-1121 > https://issues.apache.org/jira/browse/Falcon-1121 > > > Repository: falcon-git > > > Description > ------- > > See parent JIRA Falcon-1095 for detailed descriptions: http://issues.apache.org/jira/browse/Falcon-1095 > Four changes in total: > 1. Added API support: return feeds and processes if :entity-type is set to schedulable; change parameter for subsequence matching from "pattern" to "nameseq"; multi-keyword matching for entity tags with parameter "tagkeys". > 2. Added command line support. > 3. Added unit tests. > 4. Updated twiki. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 7d56b01 > client/src/main/java/org/apache/falcon/client/FalconClient.java fedcea6 > client/src/main/java/org/apache/falcon/entity/v0/Entity.java 7fb271d > client/src/main/java/org/apache/falcon/resource/EntityList.java 4c96195 > common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java b84371f > docs/src/site/twiki/FalconCLI.twiki 0e42ae2 > docs/src/site/twiki/restapi/EntityList.twiki 08dd304 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 25cb312 > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 6198c74 > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 6ccfd09 > prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java 9b0dec5 > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 82a622c > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java dd14e9c > webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java ee5534a > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 280253d > > Diff: https://reviews.apache.org/r/32946/diff/ > > > Testing > ------- > > Unit tests passed. Also tested command line and using api calls. > > > Thanks, > > Ying Zheng > > --===============6971040388704812749==--