Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2C0EB17B5D for ; Tue, 21 Apr 2015 22:55:49 +0000 (UTC) Received: (qmail 65077 invoked by uid 500); 21 Apr 2015 22:55:49 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 65037 invoked by uid 500); 21 Apr 2015 22:55:49 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 65026 invoked by uid 99); 21 Apr 2015 22:55:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Apr 2015 22:55:48 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: message received from 54.164.171.186 which is an MX secondary for dev@falcon.apache.org) Received: from [54.164.171.186] (HELO mx1-us-east.apache.org) (54.164.171.186) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Apr 2015 22:55:43 +0000 Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id D37E343EA8 for ; Tue, 21 Apr 2015 22:55:10 +0000 (UTC) Received: (qmail 64804 invoked by uid 99); 21 Apr 2015 22:55:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Apr 2015 22:55:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BC0EC1CE0CC; Tue, 21 Apr 2015 22:55:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1979702507515510701==" MIME-Version: 1.0 Subject: Re: Review Request 31793: Secure Kerberos setup : Falcon should periodically revalidate auth token. From: "Sowmya Ramesh" To: "Balu Vellanki" , "Sowmya Ramesh" , "Falcon" Date: Tue, 21 Apr 2015 22:55:11 -0000 Message-ID: <20150421225511.2947.62711@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sowmya Ramesh" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/31793/ X-Sender: "Sowmya Ramesh" References: <20150306074113.12263.9084@reviews.apache.org> In-Reply-To: <20150306074113.12263.9084@reviews.apache.org> Reply-To: "Sowmya Ramesh" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============1979702507515510701== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31793/#review81080 ----------------------------------------------------------- common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java With Falcon-1144 dependency was updated to common-langs3. Can you use org.apache.commons.lang3.StringUtils instead? common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java Is this used anywhere else? If not make it private. Also this property is not in startup.properties currently, can you add it so that user knows it can be overridden. common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java Can we add the granularity of time to constant? Is it in ms? common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java Do we want to catch NumberFormatException and return more helpful error message? common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java alertLogCleanupServiceFailed seems inappropriate, can you add a new alert method? - Sowmya Ramesh On March 6, 2015, 7:41 a.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31793/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 7:41 a.m.) > > > Review request for Falcon. > > > Bugs: https://issues.apache.org/jira/browse/FALCON-954 > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-954 > > > Repository: falcon-git > > > Description > ------- > > Secure Kerberos setup : Falcon should periodically revalidate auth token. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java fbed283 > > Diff: https://reviews.apache.org/r/31793/diff/ > > > Testing > ------- > > Ran unit and system tests. Successfully started Falcon in secure mode. > > > Thanks, > > Balu Vellanki > > --===============1979702507515510701==--