falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ying Zheng" <yzh...@hortonworks.com>
Subject Re: Review Request 32946: Falcon-1121: Backend Support for Free-text Entity Search
Date Mon, 27 Apr 2015 21:44:39 GMT


> On April 25, 2015, 3:25 a.m., Ajay Yadava wrote:
> > client/src/main/java/org/apache/falcon/resource/EntityList.java, line 76
> > <https://reviews.apache.org/r/32946/diff/7/?file=940065#file940065line76>
> >
> >     Please rename the variable to be "clusters" to be consistent with XmlElementWrapper.
Inconsistency results in issues in regression tests.

This is to be consistent with our old style:
        
        @XmlElementWrapper(name = "tags")
        public List<String> tag;
        @XmlElementWrapper(name = "pipelines")
        public List<String> pipeline;
        @XmlElementWrapper(name = "clusters")
        public List<String> cluster;
        
In the XML output, you'll see a parent element "clusters" followed by a few child elements
"cluster" with cluster information. Same for tag and pipeline.


> On April 25, 2015, 3:25 a.m., Ajay Yadava wrote:
> > client/src/main/java/org/apache/falcon/resource/EntityList.java, line 95
> > <https://reviews.apache.org/r/32946/diff/7/?file=940065#file940065line95>
> >
> >     StringUtils.isNotEmpty will be more concise and readable.

This is type LIST, not type STRING. There is no function "isNotEmpty".


> On April 25, 2015, 3:25 a.m., Ajay Yadava wrote:
> > client/src/main/java/org/apache/falcon/resource/EntityList.java, line 41
> > <https://reviews.apache.org/r/32946/diff/7/?file=940065#file940065line41>
> >
> >     Any particular reason to not make it an int?

Good catch. Yes, it's better to use int. I've updated the patch.


- Ying


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32946/#review81504
-----------------------------------------------------------


On April 22, 2015, 10:50 p.m., Ying Zheng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32946/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 10:50 p.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, Seetharam Venkatesh, and Venkat
Ranganathan.
> 
> 
> Bugs: Falcon-1121
>     https://issues.apache.org/jira/browse/Falcon-1121
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> See parent JIRA Falcon-1095 for detailed descriptions: http://issues.apache.org/jira/browse/Falcon-1095
> Four changes in total:
> 1. Added API support: return feeds and processes if :entity-type is set to schedulable;
change parameter for subsequence matching from "pattern" to "nameseq"; multi-keyword matching
for entity tags with parameter "tagkeys".
> 2. Added command line support.
> 3. Added unit tests.
> 4. Updated twiki.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 7d56b01 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java fedcea6 
>   client/src/main/java/org/apache/falcon/entity/v0/Entity.java 7fb271d 
>   client/src/main/java/org/apache/falcon/resource/EntityList.java 4c96195 
>   common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java b84371f

>   docs/src/site/twiki/FalconCLI.twiki 0e42ae2 
>   docs/src/site/twiki/restapi/EntityList.twiki 08dd304 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 25cb312 
>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
6198c74 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
6ccfd09 
>   prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java 9b0dec5 
>   webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 82a622c

>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java dd14e9c 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java ee5534a 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 280253d

> 
> Diff: https://reviews.apache.org/r/32946/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed. Also tested command line and using api calls.
> 
> 
> Thanks,
> 
> Ying Zheng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message