falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Isaychuk" <pisayc...@hortonworks.com>
Subject Re: Review Request 33396: [FALCON-1171] Adding tests for search API
Date Thu, 23 Apr 2015 14:06:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33396/
-----------------------------------------------------------

(Updated April 23, 2015, 2:06 p.m.)


Review request for Falcon.


Changes
-------

1) new 5 test cases
2) few existing test cases changed
3) both basic input and output feeds which don't have tags are taken into account
4) documentation added
5) migration from arrays to lists
6) SearchResult renamed into Result (it is contained by SearchApiTest, thus it's clear that
it relates to search api:)
7) replace validations to Result class

Both testing and checkstyle verfication done


Bugs: FALCON-1171
    https://issues.apache.org/jira/browse/FALCON-1171


Repository: falcon-git


Description
-------

Adding tests for search API


Diffs (updated)
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java
b899f1a 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SearchApiTest.java PRE-CREATION

  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java
3ae44e6 

Diff: https://reviews.apache.org/r/33396/diff/


Testing
-------

All tests pass


Thanks,

Paul Isaychuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message