falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ying Zheng" <yzh...@hortonworks.com>
Subject Re: Review Request 33328: FALCON-1158 Rename the parameter "pattern" in LIST API to "nameseq"
Date Mon, 20 Apr 2015 18:23:13 GMT


> On April 20, 2015, 2:26 p.m., Scott Preece wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 373
> > <https://reviews.apache.org/r/33328/diff/1/?file=934356#file934356line373>
> >
> >     I can't believe I didn't notice it during the earlier review, but shouldn't
nameseq be "nameSeq" or "nameSubSeq"?

Scott: The reason to use "nameseq" is to make it consistent with the parameter "nameseq" used
in the API and CLI. But I can rename to "nameSubsequence" for better readability in Falcon-1121
(https://reviews.apache.org/r/32946/), since this patch is already checked in to apache branch.


- Ying


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33328/#review80719
-----------------------------------------------------------


On April 18, 2015, 1:44 a.m., Ying Zheng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33328/
> -----------------------------------------------------------
> 
> (Updated April 18, 2015, 1:44 a.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1158
>     https://issues.apache.org/jira/browse/FALCON-1158
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Rename the new parameter "pattern" to "nameseq" in LIST API. So we don't need to worry
about the backward compatibility issue after submitting patch for FALCON-1121. Also added
documentation on how to use this parameter with examples.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 4ea9fc3 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 8b40ef2 
>   docs/src/site/twiki/FalconCLI.twiki 22ffbe7 
>   docs/src/site/twiki/restapi/EntityList.twiki 5e11691 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 1e2fc82 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
8bfc099 
>   webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 4740c71

>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java bfad011 
> 
> Diff: https://reviews.apache.org/r/33328/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed. Also tested command line and using api calls.
> 
> 
> Thanks,
> 
> Ying Zheng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message