falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 33025: FALCON-1146 : feed retention policy deleted everything all the way up to the root
Date Fri, 10 Apr 2015 17:24:09 GMT


> On April 10, 2015, 5:25 a.m., Pallavi Rao wrote:
> > retention/src/test/java/org/apache/falcon/retention/FeedEvictorTest.java, line 392
> > <https://reviews.apache.org/r/33025/diff/1/?file=921767#file921767line392>
> >
> >     The code fix is fine. But, don't think this test tests the patch sufficiently.
If the retention limit is 10 days, nothing should ideally get deleted as we produce only 10
instances of data.
> 
> Peeyush Bishnoi wrote:
>     I agree that nothing should ideally get deleted if retention limit is 10 days with
10 instances. But in this test case we have more than 10 instances thats why only 10 days
data has been retained after eviction.
>     $ ls retention/webapp/target/tmp-hadoop-pbishnoi/jail-fs/test/data/YYYY/feed1/mmHH/dd/MM/2015/04/
>     01	02	03	04	05	06	07	08	09	10
>     
>     Also, here we have just re-enabled the testcase testEvictionWithEmptyDirs().
> 
> Pallavi Rao wrote:
>     I understand this test was just re-enabled. We should either modify this test or
add a new one to specifically test your patch. Since not all instances get removed, the parent
dirs removal code path won't get tested.
> 
> Sowmya Ramesh wrote:
>     Agree with Pallavi. Using these magic numbers in tests is not readable. Test should
be modified so that after eviction there will be no content under feed base path dir.

Already developed the testcase for this scenario. Will upload.


- Peeyush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33025/#review79641
-----------------------------------------------------------


On April 9, 2015, 5:54 p.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33025/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 5:54 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1146
>     https://issues.apache.org/jira/browse/FALCON-1146
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1146 : feed retention policy deleted everything all the way up to the root
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java a5caf8e 
>   retention/src/test/java/org/apache/falcon/retention/FeedEvictorTest.java a2feccf 
> 
> Diff: https://reviews.apache.org/r/33025/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message