falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 32946: Falcon-1121: Backend Support for Free-text Entity Search
Date Thu, 09 Apr 2015 06:15:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32946/#review79482
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/32946/#comment128892>

    Although "nameseq" is better than the original pattern, things have changed since last
discussion. I think current API is now committed to 0.6.1 branch and this change is not so
it will break backward compatibility.



docs/src/site/twiki/restapi/EntityList.twiki
<https://reviews.apache.org/r/32946/#comment128893>

    Although I understand the difference between tagey and tags option(thanks @Ying!) it will
be immensely beneficial for users to document when to use which one.


- Ajay Yadava


On April 8, 2015, 1:05 a.m., Ying Zheng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32946/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 1:05 a.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, Seetharam Venkatesh, and Venkat
Ranganathan.
> 
> 
> Bugs: Falcon-1121
>     https://issues.apache.org/jira/browse/Falcon-1121
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> See parent JIRA Falcon-1095 for detailed descriptions: http://issues.apache.org/jira/browse/Falcon-1095
> Four changes in total:
> 1. Added API support: return feeds and processes if :entity-type is set to schedulable;
change parameter for subsequence matching from "pattern" to "nameseq"; multi-keyword matching
for entity tags with parameter "tagkey".
> 2. Added command line support.
> 3. Added unit tests.
> 4. Updated twiki.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 958ea62 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 15691a6 
>   client/src/main/java/org/apache/falcon/entity/v0/Entity.java 7fb271d 
>   client/src/main/java/org/apache/falcon/resource/EntityList.java d43418c 
>   common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java 1c1c325

>   docs/src/site/twiki/FalconCLI.twiki 22ffbe7 
>   docs/src/site/twiki/restapi/EntityList.twiki 5e11691 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c0df4d6 
>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
f7c2f61 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
8bfc099 
>   prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java 6f75111 
>   webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 261a9a9

>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java bfad011 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java ee5534a 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 280253d

> 
> Diff: https://reviews.apache.org/r/32946/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed. Also tested command line and using api calls.
> 
> 
> Thanks,
> 
> Ying Zheng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message