Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C0AB1096A for ; Thu, 5 Mar 2015 20:44:11 +0000 (UTC) Received: (qmail 11388 invoked by uid 500); 5 Mar 2015 20:44:06 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 11343 invoked by uid 500); 5 Mar 2015 20:44:06 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 11332 invoked by uid 99); 5 Mar 2015 20:44:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Mar 2015 20:44:06 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 05 Mar 2015 20:44:05 +0000 Received: (qmail 11138 invoked by uid 99); 5 Mar 2015 20:43:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Mar 2015 20:43:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B98961D3198; Thu, 5 Mar 2015 20:43:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0391059291530910050==" MIME-Version: 1.0 Subject: Re: Review Request 31133: Adding validations to InstanceParamsTest in falcon-regression From: "Raghav Gautam" To: "Karishma Gulati" , "Raghav Gautam" , "Falcon" Date: Thu, 05 Mar 2015 20:43:43 -0000 Message-ID: <20150305204343.12263.66522@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Raghav Gautam" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/31133/ X-Sender: "Raghav Gautam" References: <20150217203031.21353.65822@reviews.apache.org> In-Reply-To: <20150217203031.21353.65822@reviews.apache.org> Reply-To: "Raghav Gautam" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============0391059291530910050== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31133/#review75387 ----------------------------------------------------------- falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java Can we name variables like prismResponse, cluster1Response ? Using two variables should be fine. Also, applicable for other methods. I may be missing something here, but why cluster1Response will have only 5 instances and prismResponse will have 15 ? - Raghav Gautam On Feb. 17, 2015, 12:30 p.m., Karishma Gulati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31133/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 12:30 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > InstanceParamsTest currently just hits the api and logs the response. Adding validations to the test to validate the response > > > Diffs > ----- > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java c8b76e9 > > Diff: https://reviews.apache.org/r/31133/diff/ > > > Testing > ------- > > Made changes to InstanceParamsTest > > > Thanks, > > Karishma Gulati > > --===============0391059291530910050==--