falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ruslan Ostafiychuk" <rostafiyc...@hortonworks.com>
Subject Re: Review Request 32392: [FALCON-1113] Clean up data files in merlin resource directory. Create better names for them.
Date Tue, 24 Mar 2015 15:32:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32392/#review77577
-----------------------------------------------------------

Ship it!


Ship It!

- Ruslan Ostafiychuk


On March 24, 2015, 8:43 a.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32392/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 8:43 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1113
>     https://issues.apache.org/jira/browse/FALCON-1113
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> 1. Currently many of the data files have all sorts of names and contents: *.java.ignore
we need to clean this up and rename it in a way that conveys the purpose of these files.
> 2. We need to figure out do we have redundant data files. If so then remove them and
change code to use the same files.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java
cc9e7eade592a4bd8d296f508e2dbc8699df16a0 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
9751003cff58c717a03be1b413aa52779e7560ad 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java
f3a8318fbab22fec9ff230cf628fd5e82618ce39 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
338d90a97eb867eaaf7becb6071f873ddc9d4ff9 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java
7cb98cf2d97bd4c19aeef56e419aea90fb046c74 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatRetentionTest.java
83554e26bed4d87c7e918eda638e9cd898c0c8a3 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java
b51c4a41b486161eb79e0c6bcd1f5cc76358ff78 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java
c049a7ebe28a0c5d85fb967a62c8a36c42d49ecc 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/Configuration.java.ignore
1ab01400868993078d0f007aa5e125df8f6161a6 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/DateValidator.java.ignore
f02ed34a5788929f5574d2aa94e2993cb899e805 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/TimeUnit.java.ignore
67f9d4c8eb22e9507113c5231957d49e4c694959 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/dataFile1.txt
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/dataFile2.txt
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/dataFile3.txt
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/lateData/log_15.txt
f3f94c512b2b88a3949aff4ece047625cbf478ad 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/EntityInstanceMessage.java.ignore
f992f21c73f05c8c9a07f50f7611f68402c485b1 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/EntityInstanceMessageCreator.java.ignore
f7e8bbbc7e219b033588f3426075245eee6aa7c1 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/MessageProducer.java.ignore
7234f52c416991f5a45abc5e458fe5d6ca634947 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/dataFile.properties
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/dataFile.xml
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/dataFile1.txt
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/dataFile2.txt
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/dataFile3.txt
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/dataFile4.txt
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/jms-config.properties
4d3d972ada43cc4493c1fe0d93a2f0b474cb964e 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/log4j.xml
045002c82525151b09a86f6f319cf411a2ddb413 
>   falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/log_01.txt
64434fbc01b07cb6767faeba48fb9ef92a649804 
>   falcon-regression/merlin/src/test/resources/ReplicationResources/cluster-0.1.xml 6478384e9ce3248e9d3a8f8a1af0d3e7fd56a47f

>   falcon-regression/merlin/src/test/resources/ReplicationResources/feed-s4Replication.xml
bbda0c50f18e402a4b9988d7056f9b297788dfd2 
>   falcon-regression/merlin/src/test/resources/ReplicationResources/id.pig 11f227e785aac8470c9631d4540d5a614921c8cb

>   falcon-regression/merlin/src/test/resources/ReplicationResources/log4testng.properties
34b4bde25e55d981fb5d1ede87733fd0e62fdfa2 
>   falcon-regression/merlin/src/test/resources/ReplicationResources/process-agg.xml edfc1af649bebb2265894913f9fa5e56f0bd1840

>   falcon-regression/merlin/src/test/resources/feed-s4Replication.xml 719c6841fcff65456c57e137a99a9b65569f9139

>   falcon-regression/merlin/src/test/resources/log_01.txt 29a116d41befd85c2df42afb4b472cb72e11304e

> 
> Diff: https://reviews.apache.org/r/32392/diff/
> 
> 
> Testing
> -------
> 
> tested
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message