falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 31668: FALCON-1031 Make post processing notifications to user topics optional
Date Mon, 23 Mar 2015 04:15:02 GMT


> On March 22, 2015, 7:18 p.m., shaik idris wrote:
> > common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java, line
67
> > <https://reviews.apache.org/r/31668/diff/3/?file=895576#file895576line67>
> >
> >     In cluster XSD.
> >      <xs:element type="interface" name="interface" maxOccurs="unbounded" minOccurs="3"/>
> >      so, we might need to relax this check.

I was thinking the 3 occurences apply to readonly, write and execute, coz., without these
you pretty much can't have a valid process. If that is not the case, we can relax.


- Pallavi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31668/#review77358
-----------------------------------------------------------


On March 16, 2015, 12:05 p.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31668/
> -----------------------------------------------------------
> 
> (Updated March 16, 2015, 12:05 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1031
>     https://issues.apache.org/jira/browse/FALCON-1031
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Making messaging interface optional in cluster definition. If it is not specified, user
job completion notifications will not be generated for the processes that belong to the cluster.

> 
> This patch doesn't handle disabling notifications individually for a process.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 6a363b6 
>   common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 87b61a4

>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionArgs.java 0a8be64

>   common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java a807e80

>   common/src/test/resources/config/cluster/cluster-no-messaging.xml PRE-CREATION 
>   docs/src/site/twiki/EntitySpecification.twiki 66fcd2f 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieCoordinatorBuilder.java e5d75fb 
>   oozie/src/main/java/org/apache/falcon/workflow/FalconPostProcessing.java e5b3704 
>   oozie/src/main/resources/action/post-process.xml f354351 
>   oozie/src/test/java/org/apache/falcon/oozie/workflow/FalconPostProcessingTest.java
f08949d 
> 
> Diff: https://reviews.apache.org/r/31668/diff/
> 
> 
> Testing
> -------
> 
> UTs added. End-to-end testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message