falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan" <srik...@hotmail.com>
Subject Re: Review Request 31660: Falcon-822: Exposed API for reverse lookup
Date Tue, 10 Mar 2015 06:46:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31660/#review75860
-----------------------------------------------------------

Ship it!


Ship It!

- Srikanth Sundarrajan


On March 4, 2015, 2:12 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31660/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 2:12 p.m.)
> 
> 
> Review request for Falcon and Srikanth Sundarrajan.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/FALCON-822
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-822
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Falcon-822: Exposed an API over radix tree to enable users to reverse look up the feed
name using a feed instance path. Also addressed FALCON-1037 to handle trailing slashes. First
set of review comments given in JIRA are also addressed
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/ResponseHelper.java 7d5cbe5 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 92b5347 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java a866bb0 
>   client/src/main/java/org/apache/falcon/resource/FeedLookupResult.java PRE-CREATION

>   common/src/main/java/org/apache/falcon/entity/store/FeedLocationStore.java e056d96

>   common/src/main/java/org/apache/falcon/util/FalconRadixUtils.java bbd73c7 
>   common/src/main/java/org/apache/falcon/util/RadixTree.java 6cd79f5 
>   common/src/main/resources/startup.properties 433c2a8 
>   common/src/test/java/org/apache/falcon/entity/store/FeedLocationStoreTest.java 86ef775

>   common/src/test/java/org/apache/falcon/util/RadixTreeTest.java 109c24d 
>   docs/src/site/twiki/FalconCLI.twiki d503d22 
>   docs/src/site/twiki/restapi/FeedLookup.twiki PRE-CREATION 
>   docs/src/site/twiki/restapi/ResourceList.twiki 2f37bb3 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 9a044d9 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
5f711ee 
>   prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java 9504d3f 
>   src/conf/startup.properties 2db4b1e 
>   webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java a83f0cf

>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java d46f112 
> 
> Diff: https://reviews.apache.org/r/31660/diff/
> 
> 
> Testing
> -------
> 
> Unit tests and Integration tests are added. 
> 
> ( I have also addresssed the first set of code review comments & Falcon-1037 as well
to handle trailing slashes)
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message