falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <rag...@apache.org>
Subject Re: Review Request 31133: Adding validations to InstanceParamsTest in falcon-regression
Date Thu, 05 Mar 2015 20:43:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31133/#review75387
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java
<https://reviews.apache.org/r/31133/#comment122404>

    Can we name variables like prismResponse, cluster1Response ? Using two variables should
be fine. Also, applicable for other methods.
    
    I may be missing something here, but why cluster1Response will have only 5 instances and
prismResponse will have 15 ?


- Raghav Gautam


On Feb. 17, 2015, 12:30 p.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31133/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 12:30 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> InstanceParamsTest currently just hits the api and logs the response. Adding validations
to the test to validate the response
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java
c8b76e9 
> 
> Diff: https://reviews.apache.org/r/31133/diff/
> 
> 
> Testing
> -------
> 
> Made changes to InstanceParamsTest
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message