falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan" <srik...@hotmail.com>
Subject Re: Review Request 31672: Rerun does not work on succeeded instances
Date Tue, 03 Mar 2015 12:15:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31672/#review74937
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/31672/#comment121818>

    Is it going to be force-rerun & rerun or rerun & continue ? Looks like we are
gravitating towards the former.



prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java
<https://reviews.apache.org/r/31672/#comment121819>

    Why can't this be a String.valueOf() unconditionally ?



webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java
<https://reviews.apache.org/r/31672/#comment121820>

    Can tests be added? Also this is user facing feature. Docs are needed.


- Srikanth Sundarrajan


On March 3, 2015, 9:28 a.m., Suhas  Vasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31672/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 9:28 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Falcon rerun does not work for succeeded instances. ProcessInstanceRerunTest.testProcessInstanceRerunMultipleSucceeded
and ProcessInstanceRerunTest.testProcessInstanceRerunSingleSucceeded is failing becuase of
this.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java ac76a9c 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 86397c4 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
6b10679 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 169856c

>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java ed30869

>   prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 7f261ce 
>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java e6cf904

>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java d4e0ae0 
> 
> Diff: https://reviews.apache.org/r/31672/diff/
> 
> 
> Testing
> -------
> 
> Have verified this manually
> 
> 
> Thanks,
> 
> Suhas  Vasu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message