falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "samarth gupta" <samarthgupta...@gmail.com>
Subject Re: Review Request 31622: Add test in falcon regression to test loading of jar present in user lib
Date Tue, 03 Mar 2015 05:09:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31622/#review74892
-----------------------------------------------------------



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java
<https://reviews.apache.org/r/31622/#comment121716>

    pls rename the variable to more logical name. Like oozie_example_lib . Same for the property
also.



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java
<https://reviews.apache.org/r/31622/#comment121717>

    try to extract the file name from the url above itself.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathLoadTest.java
<https://reviews.apache.org/r/31622/#comment121719>

    try to reduce the time for which data is being uploaded. process validity is very less,
only for one instance. I dont 3 hrs of data would be required for that .



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathLoadTest.java
<https://reviews.apache.org/r/31622/#comment121718>

    why is "pig" resource being used here ? i though we were using main classs from oozie
example jar.


- samarth gupta


On March 2, 2015, 10:40 a.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31622/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 10:40 a.m.)
> 
> 
> Review request for Falcon and samarth gupta.
> 
> 
> Bugs: FALCON-964
>     https://issues.apache.org/jira/browse/FALCON-964
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This test points to a jar at remote public location that can be downloaded when test
are run.It tests important feature of user provided libs / jars being loaded and used by tasktracker
/ nodemanager while launching the actual task.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java
1c517b4 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java
dd5e194 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathLoadTest.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/oozieLib/workflow.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31622/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message