Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0F99F175AB for ; Tue, 24 Feb 2015 08:49:52 +0000 (UTC) Received: (qmail 72523 invoked by uid 500); 24 Feb 2015 08:49:52 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 72493 invoked by uid 500); 24 Feb 2015 08:49:51 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 72470 invoked by uid 99); 24 Feb 2015 08:49:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Feb 2015 08:49:51 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 24 Feb 2015 08:49:50 +0000 Received: (qmail 72422 invoked by uid 99); 24 Feb 2015 08:49:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Feb 2015 08:49:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 746951CBFD4; Tue, 24 Feb 2015 08:49:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8852458427830589688==" MIME-Version: 1.0 Subject: Re: Review Request 30721: FeedReplicationTest modified to check for _SUCCESS getting created on target directory From: "PRAGYA MITTAL" To: "samarth gupta" , "Falcon" , "PRAGYA MITTAL" Date: Tue, 24 Feb 2015 08:49:28 -0000 Message-ID: <20150224084928.4174.60216@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "PRAGYA MITTAL" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/30721/ X-Sender: "PRAGYA MITTAL" References: <20150223071905.4174.9882@reviews.apache.org> In-Reply-To: <20150223071905.4174.9882@reviews.apache.org> Reply-To: "PRAGYA MITTAL" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============8852458427830589688== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 23, 2015, 7:19 a.m., samarth gupta wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java, line 144 > > > > > > in remote case it might be possible that file name may contain "_SUCCESS" . Its better to check for exact name, since we are sure it should be _SUCCESS. Adding check for file name itself instead of checking a part of it > On Feb. 23, 2015, 7:19 a.m., samarth gupta wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java, line 145 > > > > > > we can directly have return statement here "return true" Will modify the test - PRAGYA ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30721/#review73527 ----------------------------------------------------------- On Feb. 6, 2015, 9:27 a.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30721/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2015, 9:27 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1017 and FALCON-556 > https://issues.apache.org/jira/browse/FALCON-1017 > https://issues.apache.org/jira/browse/FALCON-556 > > > Repository: falcon-git > > > Description > ------- > > Modifying FeedReplicationTest to check for _SUCCESS availability on target directory as per FALCON-556 > > > Diffs > ----- > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java 64574a5 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java b88cffc > > Diff: https://reviews.apache.org/r/30721/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > PRAGYA MITTAL > > --===============8852458427830589688==--