falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-1025) lastWeek and CurrentWeek functions are getting evaluated incorrect
Date Fri, 20 Feb 2015 05:58:11 GMT

    [ https://issues.apache.org/jira/browse/FALCON-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328596#comment-14328596
] 

Pallavi Rao commented on FALCON-1025:
-------------------------------------

Couple of comments:
1. FORMATTER doesn't need to be a ThreadLocal variable. You are using a fixed format that
doesn't change per thread. It can just be a static variable.
2. Use the format we use everywhere else, which is "yyyy-MM-dd'T'HH:mm'Z'"

Otherwise, the code looks good.

> lastWeek and CurrentWeek functions are getting evaluated incorrect
> ------------------------------------------------------------------
>
>                 Key: FALCON-1025
>                 URL: https://issues.apache.org/jira/browse/FALCON-1025
>             Project: Falcon
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 0.7
>            Reporter: pavan kumar kolamuri
>            Assignee: pavan kumar kolamuri
>         Attachments: FALCON-1025-v1.patch, FALCON-1025.patch
>
>
> In Data input section in process currentWeek and lastWeek are getting evaluated incorrectly.

> Ex: Current time is 13th Feb 7th hour 
> currentWeek('WED',0,0) getting evaluated to Fri Jan 30 00:00:00 UTC 2015  it should evaluate
to Wed Feb 11 00:00:00 UTC 2015
> Even the lastWeek is getting evaluated in correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message